fix(ci,makefile): add a new release Makefile target to pass LDFLAGS to goreleaser
#25
Conversation
… to goreleaser. Signed-off-by: Federico Di Pierro <[email protected]>
|
@FedeDP: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
There is not a label identifying the kind of this PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cc @maxgio92 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, maxgio92 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
We were not passing LDFLAGS to goreleaser, so driverkit "latest" builder images were being used.
Added a new Makefile
releasetarget that passes LDFLAGS to goreleaser.I avoided using
ldflagsgoreleaser config key because i wanted a single place where driverkit version was declared, to easily bump it (throughbump-driverkitmakefile target).Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: